Be more robust in case kubectl fails #8712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
previously approved these changes
Mar 10, 2022
fullmetalrooster
previously approved these changes
Mar 10, 2022
|
/werft run 👍 started the job as gitpod-build-me-kubectlerror.0 |
|
/hold Could you rebase now that #8711 was merged? |
meysholdt
dismissed stale reviews from fullmetalrooster and ArthurSens
via
69d0a75
meysholdt
force-pushed
the
me/kubectlerror
branch
from
2cd5813 to
69d0a75
Compare
|
ArthurSens
approved these changes
Mar 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #8712 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
kubectl get podsfails while polling the state, keep polling instead of failing.This error occurred during a load test: https://werft.gitpod-dev.com/job/gitpod-build-lod-with-vm-4.0/raw
Related Issue(s)
Fixes #
How to test
Potentially only reproducible during load test.
Release Notes
Documentation